Genode on RPI - end of discovery stage
stefan.kalkowski at genode-labs.com
Tue Jun 11 15:43:31 CEST 2019
On Mon, Jun 10, 2019 at 12:54:46AM +0200, Tomasz Gajewski wrote:
> Tomasz Gajewski <tomga at wp.pl> writes:
> > There are some minor things that probably should be fixed, though. I
> > see at least:
> > - license header update
> > - some minor formatting issues: indentation and some old commented
> > code
> > - I'm not sure if _wait_until_ready() is ok - busy loop in kernel
> > code? (sometimes I suspected that some exceptions and hangs I had
> > were connected with this function, although I'm not sure)
> > I would address those isseus before proposing merge but if you need it
> > now then go ahead and make changes you think are suitable.
> Stefan, I've seen you made a commit which renames this mini uart driver
> in your branch. I've started the cleanup of commits and I'd like to
> incorporate this rename into my branch to avoid merge conflicts
> Do you have any objections that I merge this into my one commit for uart
> driver, or would you like to have it separate (as three: my original,
> your rename, and my cleanup)?
> Additionally - do you have any changes to this driver that you did not
> push yet that could cause merge conflicts?
I've no objections at all. Please proceed with either your original
commit, and mine to be separate or merged. I only did this separate
fixup commit, so that it is transparent to you. In the final version
on staging resp. master it will be merged anyway.
I do not have additional changes.
> I also have one more general question about further processing of
> getting my changes to genode repositories. I'll cleanup the code and
> split commits into parts that contain specific features but should I
> open different issues on github for each of them or one for all changes
> I made for rpi is enough? I think it would be better to process them
> individually but as they depend on each other I want to hear your
I would say: it depends. In general, it is surely better to have
separate issues for different features. But if there is a small fix in
some let's say irq controller driver, which enables to use the same
driver for rpi 1 and 3, it is ok to put the corresponding commit into
the same issue here.
Please, feel free to go ahead and incorporate what you want to. If we
hit any collaboration problems thereby, we will find a solution
https://github.com.skalk | https://genode.org
More information about the users