[GSoC] UEFI framebuffer task

Sebastian Sumpf Sebastian.Sumpf at ...1...
Fri Mar 31 14:35:37 CEST 2017


Hi Philipp,

On 03/30/2017 10:59 PM, Philipp Kerling wrote:
> Hi,
> 
> You can now review the code at 
> https://github.com/pkerling/genode/commit/4130907
> I have to admit that it's mostly copypaste from the AHCI driver.
> I tested it successfully with both base-hw and NOVA. My output is:
> 
> $ make run/nvme_test
> [...]
> Genode 17.02-148-g41309074e <local changes>
> 58 MiB RAM assigned to init
> [...]
> [init -> nvme_drv] NVMe demo
> [init -> nvme_drv] NVMe found (vendor: 0x8086 device: 0x5845 class: 0x10802)
> [init -> nvme_drv] BAR0: 0xfebf0000, size: 0x2000
> [init -> nvme_drv] Controller supports NVMe version 1.1.0
> [init -> nvme_drv] Memory pages from 4096 to 65536 bytes supported
> [init -> nvme_drv] 2048 maximum entries per queue
> [init -> nvme_drv] --- NVMe demo finished ---

I have had a look at your code and tested in on NOVA as well. No
objections from my side - good job.

Next I would suggest to finish your proposal (item 15) and mark it as
final until Monday.

Cheers,

Sebastian


-- 
Sebastian Sumpf
Genode Labs

http://www.genode-labs.com · http://genode.org

Genode Labs GmbH · Amtsgericht Dresden · HRB 28424 · Sitz Dresden
Geschäftsführer: Dr.-Ing. Norman Feske, Christian Helmuth







More information about the users mailing list