tool_chain

[Julian Stecklina]

Christian Helmuth <christian.helmuth at ...1...> writes:

> On Wed, May 27, 2009 at 10:30:22PM +0200, Julian Stecklina wrote:
>> diff --git a/tool/tool_chain b/tool/tool_chain
>> index e830712..887b899 100755
>> --- a/tool/tool_chain
>> +++ b/tool/tool_chain
>> @@ -14,9 +14,10 @@ BINUTILS_DOWNLOAD_URL = http://ftp.gnu.org/gnu/binutils
>>  #
>>  # Tool versions and install location
>>  #
>> -GCC_VERSION      = 4.2.4
>> -BINUTILS_VERSION = 2.18
>> -INSTALL_LOCATION = /usr/local/genode-gcc
>> +GCC_VERSION      ?= 4.2.4
>> +BINUTILS_VERSION ?= 2.18
>> +INSTALL_LOCATION ?= /usr/local/genode-gcc
>> +USE_SUDO         ?= yes
>
> This variable is not used later in the script. Did you mean NOSUDO?

Yes. I should not try to produce a meaningful patch when I am tired. ;)

>>  clean:
>>  	rm -rf binutils-$(BINUTILS_VERSION) gcc-$(GCC_VERSION)
>> @@ -124,7 +137,7 @@ cleanall: clean
>>  	rm -rf binutils-$(BINUTILS_VERSION).tar.gz
>>  	rm -rf gcc-core-$(GCC_VERSION).tar.bz2
>>  	rm -rf gcc-g++-$(GCC_VERSION).tar.bz2
>> -	rm -rf gcc_build_$(PLATFORM)
>> +	rm -rf gcc_build_x86
>
> Why not use PLATFORM here?

Because it is only set, when the target is x86. I changed that a bit in
the attached second try.

Regards,
-- 
Julian Stecklina

The day Microsoft makes something that doesn't suck is probably the day
they start making vacuum cleaners - Ernst Jan Plugge
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tool_chain-custom2.patch
Type: text/x-patch
Size: 4103 bytes
Desc: not available
URL: <http://lists.genode.org/pipermail/users/attachments/20090528/fca85f01/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.genode.org/pipermail/users/attachments/20090528/fca85f01/attachment.sig>